Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1653353002: [turbofan] Move creation stub fallbacks to JSGenericLowering. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move creation stub fallbacks to JSGenericLowering. Move all the code that deals with falling back to object creation via stubs to JSGenericLowering, where we can already deal well with stub calls. This includes JSCreateLiteralArray, JSCreateLiteralObject, JSCreateClosure, JSCreateFunctionContext and JSCreateArray. R=mstarzinger@chromium.org Committed: https://crrev.com/7be5829971f8cb0b431f964ff7346a252c581f13 Cr-Commit-Position: refs/heads/master@{#33682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -276 lines) Patch
M src/compiler/js-generic-lowering.cc View 4 chunks +111 lines, -16 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +0 lines, -163 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 2 chunks +0 lines, -94 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 13:03:21 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, moving stuff to JSGenericLowering. I think it's even more readable ...
4 years, 10 months ago (2016-02-02 13:04:50 UTC) #2
Michael Starzinger
LGTM.
4 years, 10 months ago (2016-02-02 13:08:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653353002/1
4 years, 10 months ago (2016-02-02 13:17:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 13:33:14 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:34:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7be5829971f8cb0b431f964ff7346a252c581f13
Cr-Commit-Position: refs/heads/master@{#33682}

Powered by Google App Engine
This is Rietveld 408576698