Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165333004: Revert "Allow MessageFilters to restrict listening to specific message classes" (Closed)

Created:
6 years, 10 months ago by jdduke (slow)
Modified:
6 years, 10 months ago
Reviewers:
dxie
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, tburkard+watch_chromium.org, alecflett, rpetterson, Michael van Ouwerkerk, dcheng, cbentzel+watch_chromium.org, yukishiino+watch_chromium.org, stuartmorgan+watch_chromium.org, kinuko+watch, aandrey+blink_chromium.org, frankf+watch_chromium.org, extensions-reviews_chromium.org, craigdh+watch_chromium.org, vsevik, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, android-webview-reviews_chromium.org, michaeln, fischman+watch_chromium.org, rouslan+spellwatch_chromium.org, timvolodine, penghuang+watch_chromium.org, gavinp+prer_chromium.org, paulirish+reviews_chromium.org, bulach+watch_chromium.org, nhiroki, ilevy-cc_chromium.org, jochen+watch_chromium.org, davidben+watch_chromium.org, jsbell, feature-media-reviews_chromium.org, horo+watch_chromium.org, mcasas+watch_chromium.org, yurys, dominich+watch_chromium.org, dsinclair+watch_chromium.org, cmumford, dgrogan, klundberg+watch_chromium.org, James Su, wjia+watch_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert "Allow MessageFilters to restrict listening to specific message classes" This reverts commit 2955e4e3c747fd4aa3c227d6c4e4c698cf31b3c4. Reason for revert: Frequent crashes on Windows. BUG=345368 TBR= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -618 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/gtest/filter/ipc_tests_disabled View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_net_benchmarking_message_filter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/media/cast_transport_host_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media/encrypted_media_message_filter_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/media/webrtc_logging_handler_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_state_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/signin/principals_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/speech/tts_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_message_filter_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/browser/nacl_host_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/appcache/appcache_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/device_orientation/device_motion_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/device_orientation/device_orientation_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/devtools/worker_devtools_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/histogram_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_message_filter.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/loader/resource_scheduler_filter.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/media/android/browser_demuxer_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/message_port_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/mime_registry_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/profiler_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/quota_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/clipboard_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/file_utilities_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/gamepad_browser_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/input/touch_input_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/device_request_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/midi_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/midi_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/peer_connection_tracker_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/webrtc_identity_service_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/memory_benchmark_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_message_filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/pepper_renderer_connection.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/browser/renderer_host/socket_stream_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/websocket_dispatcher_host.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +1 line, -8 lines 0 comments Download
M content/browser/shared_worker/shared_worker_message_filter.cc View 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/speech/input_tag_speech_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/tracing/trace_message_filter.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M content/browser/vibration/vibration_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/worker_host/worker_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 3 chunks +1 line, -9 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M content/shell/browser/shell_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +0 lines, -12 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 7 chunks +6 lines, -100 lines 0 comments Download
D ipc/ipc_channel_proxy_unittest.cc View 1 chunk +0 lines, -270 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jdduke (slow)
Revert was clean, but making sure there have been no additional dependencies that would be ...
6 years, 10 months ago (2014-02-20 20:43:02 UTC) #1
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 10 months ago (2014-02-20 21:22:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/165333004/1
6 years, 10 months ago (2014-02-20 21:24:07 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 00:13:29 UTC) #4
Message was sent while issue was closed. 
Change committed as 252428

Powered by Google App Engine
This is Rietveld 408576698