Issue 165332: Mac: Make autocomplete popup track autocomplete field resizes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165332: Mac: Make autocomplete popup track autocomplete field resizes. (Closed)

Created:
11 years, 4 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Make autocomplete popup track autocomplete field resizes. http://crbug.com/17402 TEST=Enter text in the omnibox and resize the window. Popup size should follow.

Patch Set 1 #

Patch Set 2 : Oops, was unregistering for the wrong notification. #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View	1	4 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

11 years, 4 months ago (2009-08-12 14:58:10 UTC) #2

LGTM

We also need to change the popup window to span from the star button to the go
button, instead of being under just the locationbar, but that should be
orthogonal to this CL.

Expand Messages | Collapse Messages