Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 1653313002: Changed the default value for Empty Dir Attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made changes as per review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index bc3c1bd86be98f88dc2d7ee1f7e9544a13ba772f..5eaf0981b406dc98707ea8ddfad93238b4ec20b3 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -232,10 +232,14 @@ void HTMLElement::collectStyleForPresentationAttribute(const QualifiedName& name
if (equalIgnoringCase(value, "auto")) {
addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, unicodeBidiAttributeForDirAuto(this));
} else {
- if (isValidDirAttribute(value))
+ if (isValidDirAttribute(value)) {
addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
- else
- addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+ } else {
+ if (isHTMLBodyElement(*this))
kojii 2016/02/12 07:13:07 nit: better to use "else if"; i.e., if (...) ..
chakshu 2016/02/15 05:49:25 Done.
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+ else
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "");
+ }
if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueIsolate);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/elements/global-attributes/dir-empty-attribute-value-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698