third_party/WebKit/Source/core/html/HTMLElement.cpp - Issue 1653313002: Changed the default value for Empty Dir Attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 1653313002: Changed the default value for Empty Dir Attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the empty string for the style Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp

index bc3c1bd86be98f88dc2d7ee1f7e9544a13ba772f..967ba9b4ff83a23d60244bea4026bc3f677627b3 100644

--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp

@@ -234,7 +234,7 @@ void HTMLElement::collectStyleForPresentationAttribute(const QualifiedName& name

} else {

if (isValidDirAttribute(value))

addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);

- else

+ else if (isHTMLBodyElement(*this))

addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");

if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))

addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueIsolate);