Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 1653313002: Changed the default value for Empty Dir Attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index bc3c1bd86be98f88dc2d7ee1f7e9544a13ba772f..d3c3e219cc61e6baff785f1c0a8ba735d7bc2df3 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -234,8 +234,10 @@ void HTMLElement::collectStyleForPresentationAttribute(const QualifiedName& name
} else {
if (isValidDirAttribute(value))
addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
- else
+ else if (isHTMLBodyElement(*this))
addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+ else
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "");
kojii 2016/02/16 07:39:01 I should have noticed before, sorry, but is this l
chakshu 2016/02/18 09:00:58 Oh yes, even I didn't realize that. Made the chang
if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueIsolate);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/elements/global-attributes/dir-empty-attribute-value-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698