Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1653303002: Rename prelude to range in parsePageSelector (Closed)

Created:
4 years, 10 months ago by ramya.v
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename prelude to range in parsePageSelector Updated comments and renamed function parameters. BUG=580956 Committed: https://crrev.com/4ace262f890123298965dc53281a84ff1134614a Cr-Commit-Position: refs/heads/master@{#372904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ramya.v
PTAL! Thanks
4 years, 10 months ago (2016-02-02 05:43:12 UTC) #2
Timothy Loh
On 2016/02/02 05:43:12, ramya.v wrote: > PTAL! > > Thanks lgtm
4 years, 10 months ago (2016-02-02 05:43:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653303002/1
4 years, 10 months ago (2016-02-02 05:46:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 07:13:25 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 07:14:26 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4ace262f890123298965dc53281a84ff1134614a
Cr-Commit-Position: refs/heads/master@{#372904}

Powered by Google App Engine
This is Rietveld 408576698