chrome/common/origin_trials/origin_trial_key_manager.h - Issue 1653263005: [Experimental Framework] Move the trial token public key out of content and into the embedder.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/origin_trials/origin_trial_key_manager.h

Issue 1653263005: [Experimental Framework] Move the trial token public key out of content and into the embedder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase; fix DLL export error in VS compile Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/chrome_content_client.cc ('k') | chrome/common/origin_trials/origin_trial_key_manager.cc » ('j') | chrome/common/origin_trials/origin_trial_key_manager.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

	6 #define CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

	7

	8 #include "base/strings/string_piece.h"

	9

	10 class ChromeOriginTrialKeyManager {
	chasej 2016/02/05 19:35:28 The file name doesn't match the class name. I woul The file name doesn't match the class name. I would have expected the file name to be chrome_origin_trial_key_manager.h. iclelland 2016/02/05 20:18:08 Now that this doesn't implement a content/ interfa Show quoted text On 2016/02/05 19:35:28, chasej wrote: > The file name doesn't match the class name. I would have expected the file name > to be chrome_origin_trial_key_manager.h. Now that this doesn't implement a content/ interface, I've just dropped the "Chrome" prefix instead.
	11 public:

	12 base::StringPiece GetPublicKey();

	13 };

	14

	15 #endif // CHROME_COMMON_ORIGIN_TRIALS_ORIGIN_TRIAL_KEY_MANAGER_H_

OLD	NEW