Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h

Issue 1653253003: Simplify CanvasAsyncBlobCreator by removing ContextObserver and related tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Corrected virtual test suites config Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
index df7f1d787ee125dfa55e9135f2ee1bb74509d8fc..0a714c7002f366c818430f0f8bd78ac9cb854c6a 100644
--- a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
+++ b/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h
@@ -4,7 +4,6 @@
#include "core/CoreExport.h"
#include "core/dom/DOMTypedArray.h"
-#include "core/dom/ExecutionContext.h"
#include "core/fileapi/BlobCallback.h"
#include "platform/geometry/IntSize.h"
#include "platform/heap/Handle.h"
@@ -20,19 +19,15 @@ class PNGImageEncoderState;
class CORE_EXPORT CanvasAsyncBlobCreator
: public RefCounted<CanvasAsyncBlobCreator> {
public:
- static PassRefPtr<CanvasAsyncBlobCreator> create(PassRefPtr<DOMUint8ClampedArray> unpremultipliedRGBAImageData, const String& mimeType, const IntSize&, BlobCallback*, ExecutionContext*);
+ static PassRefPtr<CanvasAsyncBlobCreator> create(PassRefPtr<DOMUint8ClampedArray> unpremultipliedRGBAImageData, const String& mimeType, const IntSize&, BlobCallback*);
void scheduleAsyncBlobCreation(bool canUseIdlePeriodScheduling, double quality = 0.0);
virtual ~CanvasAsyncBlobCreator();
-protected:
- CanvasAsyncBlobCreator(PassRefPtr<DOMUint8ClampedArray> data, const String& mimeType, const IntSize&, BlobCallback*);
- virtual void scheduleCreateBlobAndCallOnMainThread();
- virtual void scheduleCreateNullptrAndCallOnMainThread();
- virtual void scheduleClearSelfRefOnMainThread();
- std::atomic<bool> m_cancelled;
-
private:
- friend class CanvasAsyncBlobCreatorTest;
+ CanvasAsyncBlobCreator(PassRefPtr<DOMUint8ClampedArray> data, const String& mimeType, const IntSize&, BlobCallback*);
+ void scheduleCreateBlobAndCallOnMainThread();
+ void scheduleCreateNullptrAndCallOnMainThread();
+ void scheduleClearSelfRefOnMainThread();
OwnPtr<PNGImageEncoderState> m_encoderState;
RefPtr<DOMUint8ClampedArray> m_data;
@@ -54,13 +49,6 @@ private:
void createBlobAndCall();
void encodeImageOnEncoderThread(double quality);
- bool initializeEncodeImageOnEncoderThread();
- void nonprogressiveEncodeImageOnEncoderThread(double quality);
- void progressiveEncodeImageOnEncoderThread();
-
- class ContextObserver;
- void createContextObserver(ExecutionContext*);
- OwnPtrWillBePersistent<ContextObserver> m_contextObserver;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698