Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 165323: Add chrome.extension to extension_api.json and docs (Closed)

Created:
11 years, 4 months ago by rafaelw
Modified:
9 years, 6 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add chrome.extension to extension_api.json and docs. This required making it so that extension_api.json definitions defer to existing bindings so that the chrome.extension object can remain setup in renderer_extension_bindings.js. Also fixed a minor bug with error handling in the api_generator.js Moved "Port" type to the new extension module. Removed a bunch of trailing whitespace from the extension_api.json. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23200

Patch Set 1 #

Patch Set 2 : added onConnect event #

Patch Set 3 : cr changes #

Patch Set 4 : precommit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -37 lines) Patch
M chrome/common/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 8 chunks +51 lines, -16 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/background_pages.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/bookmarks.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/content_scripts.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/devguide.html View 1 chunk +1 line, -1 line 0 comments Download
A chrome/common/extensions/docs/extension.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/getstarted.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/index.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/overview.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/packaging.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/pageActions.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/self.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/tabs.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/toolstrip.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/windows.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/renderer_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/extension_process_bindings.js View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rafaelw
11 years, 4 months ago (2009-08-11 21:51:05 UTC) #1
Aaron Boodman
11 years, 4 months ago (2009-08-11 21:54:53 UTC) #2
lgtm.

the comment in connect() is not correct per our discussion offline.

Powered by Google App Engine
This is Rietveld 408576698