cleanup of skia serve url handling

cleanup of skia serve url handling

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653203002

Committed: https://skia.googlesource.com/skia/+/483b90140a122972be7342cfe34b5da5979790f4

[joshua.litt, 2016-02-01 21:55:17]

Description was changed from

==========
cleanup of skia serve url handling

BUG=skia:
==========

to

==========
cleanup of skia serve url handling

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-01 21:56:07]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-02-01 21:56:07]

Ptal, this is in preparation for more complex url handling

[joshualitt, 2016-02-01 21:56:36]

ptal

[jcgregorio, 2016-02-02 12:35:31]

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:203: 0 == strcmp(url, "/img");
0 == strncmp(url, "/img", 4);

So the cache-busting ?blahblahblah will be ignored.

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:295: return fHandlers[i]->handle(request,
connection, upload_data, upload_data_size);
Please log the method and the url to stderr.

[joshualitt, 2016-02-02 14:02:34]

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.cpp
File tools/skiaserve/skiaserve.cpp (right):

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:203: 0 == strcmp(url, "/img");
On 2016/02/02 12:35:31, jcgregorio wrote:
> 0 == strncmp(url, "/img", 4);
> 
> So the cache-busting ?blahblahblah will be ignored.

Acknowledged.

https://codereview.chromium.org/1653203002/diff/1/tools/skiaserve/skiaserve.c...
tools/skiaserve/skiaserve.cpp:295: return fHandlers[i]->handle(request,
connection, upload_data, upload_data_size);
On 2016/02/02 12:35:31, jcgregorio wrote:
> Please log the method and the url to stderr.

Acknowledged.

[jcgregorio, 2016-02-02 14:07:48]

lgtm

[jcgregorio, 2016-02-02 14:07:48]

lgtm

[joshualitt, 2016-02-02 15:02:05]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-02-02 15:02:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1653203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1653203002/20001

[commit-bot: I haz the power, 2016-02-02 15:16:31]

Description was changed from

==========
cleanup of skia serve url handling

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
cleanup of skia serve url handling

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/483b90140a122972be7342cfe34b5da5979790f4
==========

[commit-bot: I haz the power, 2016-02-02 15:16:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/483b90140a122972be7342cfe34b5da5979790f4