Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1653183002: getObject now supports specifying offset,count for strings. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

getObject now supports specifying offset,count for strings. Closes #25157 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/222f6726d039655ea17e8736f3254a3fd12202b1

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -38 lines) Patch
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 1 chunk +93 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 4 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 3 chunks +19 lines, -15 lines 0 comments Download
M runtime/vm/json_test.cc View 4 chunks +18 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +18 lines, -6 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service/service.md View 1 2 6 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
4 years, 10 months ago (2016-02-01 21:47:51 UTC) #2
rmacnak
lgtm w/ unicode terminology fix https://codereview.chromium.org/1653183002/diff/20001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1653183002/diff/20001/runtime/vm/service/service.md#newcode1479 runtime/vm/service/service.md:1479: // number of codepoints ...
4 years, 10 months ago (2016-02-01 22:24:07 UTC) #4
turnidge
https://codereview.chromium.org/1653183002/diff/20001/runtime/vm/service/service.md File runtime/vm/service/service.md (right): https://codereview.chromium.org/1653183002/diff/20001/runtime/vm/service/service.md#newcode1479 runtime/vm/service/service.md:1479: // number of codepoints in a String. On 2016/02/01 ...
4 years, 10 months ago (2016-02-01 22:31:33 UTC) #5
turnidge
4 years, 10 months ago (2016-02-01 22:49:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
222f6726d039655ea17e8736f3254a3fd12202b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698