Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 165318: Lands http://codereview.chromium.org/159838 for Pierre-Antoine. From him:... (Closed)

Created:
11 years, 4 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Lands http://codereview.chromium.org/159838 for Pierre-Antoine. From him: Right clicking the back and forward buttons is buggy. A single right click opens the drop down menu, however the button does not enter the PUSHED state. If you double right click then click on the tab content area, the button stays in a PUSHED state until you mouseover it. The fix should replicate the intuitive behavior. On a single right click, the button enters the PUSHED state and the drop down appears immediately. As soon as the user clicks on another View, the drop down closes and the button returns to the NORMAL state. Double right click behaves similarly. BUG=9717 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M views/controls/button/button_dropdown.h View 2 chunks +8 lines, -1 line 0 comments Download
M views/controls/button/button_dropdown.cc View 4 chunks +22 lines, -8 lines 0 comments Download
M views/controls/button/custom_button.h View 1 chunk +5 lines, -0 lines 0 comments Download
M views/controls/button/custom_button.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698