Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1653163003: Use LinkedDependency.parts to find part URIs during resynthesis. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use LinkedDependency.parts to find part URIs during resynthesis. Now we can resynthesize a given library without having to consult any summaries other than the linked summary for the library itself and the unlinked summaries for all its compilation units. All other summaries are consulted only on demand if the information in them is needed. Tests are updated to validate this. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/24b5df4dcc399ea31c4ab29556e7fa4af6715aca

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -15 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +1 line, -7 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 8 chunks +50 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-01 21:37:50 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1653163003/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart File pkg/analyzer/test/src/summary/resynthesize_test.dart (right): https://codereview.chromium.org/1653163003/diff/1/pkg/analyzer/test/src/summary/resynthesize_test.dart#newcode122 pkg/analyzer/test/src/summary/resynthesize_test.dart:122: for (CompilationUnitElement partUnit in library.parts) { You could ...
4 years, 10 months ago (2016-02-01 21:45:22 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 24b5df4dcc399ea31c4ab29556e7fa4af6715aca (presubmit successful).
4 years, 10 months ago (2016-02-01 22:32:25 UTC) #5
Paul Berry
4 years, 10 months ago (2016-02-01 22:32:32 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1653163003/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1653163003/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:122: for
(CompilationUnitElement partUnit in library.parts) {
On 2016/02/01 21:45:22, scheglov wrote:
> You could use "library.units" and avoid the special case for the defining
unit.

Done.

Powered by Google App Engine
This is Rietveld 408576698