Issue 1653143002: Fix gen snapshot code to use Dart_LoadLibrary instead of Dart_LoadScript so that the root library v…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1653143002: Fix gen snapshot code to use Dart_LoadLibrary instead of Dart_LoadScript so that the root library v… (Closed)

Created:
4 years, 10 months ago by siva

Modified:
4 years, 10 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix gen snapshot code to use Dart_LoadLibrary instead of Dart_LoadScript so that the root library value is not set when creating the bootstrap snapshot. The root library gets set when the application is loaded in later. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cab435bd03c558b45632195901dc8278a366fccb

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/bin/gen_snapshot.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 10 months ago (2016-02-01 20:57:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cab435bd03c558b45632195901dc8278a366fccb (presubmit successful).