Retire obsolete Valgrind suppressions

Retire obsolete Valgrind suppressions

BUG=108516, 70599, 107698
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204839

[_com_google_glider, 2013-06-06 09:05:51]

Is http://crbug.com/70599 fixed already?
Ditto for http://crbug.com/107698

On Thu, Jun 6, 2013 at 12:58 PM,  <ericwilligers@chromium.org> wrote:
> Reviewers: Timur Iskhodzhanov,
>
> Description:
> Retire obsolete Valgrind suppressions
>
> BUG=70599
>
> Please review this at https://codereview.chromium.org/16531003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
b9f3339e9b192b8472453ab046c15d47e515d9d6..817893aad074220ef87d1194171ac73afc16fba6
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -1151,13 +1151,6 @@
>     fun:_ZN12_GLOBAL__N_111DnsReloader11MaybeReloadEv
>  }
>  {
> -   # Intentional - atomic strings and hash map in
> WebCore::nameToPseudoTypeMap() (CSSSelector.cpp) are to be leaked
> -   bug_108516
> -   Memcheck:Leak
> -   fun:_Znw*
> -   fun:_ZN7WebCoreL19nameToPseudoTypeMapEv
> -}
> -{
>     bug_79322 (Intentional)
>     Memcheck:Leak
>     fun:_Znw*
> @@ -2634,17 +2627,6 @@
>
>
fun:_ZN3gfx10Canvas13SizeStringIntERKSbItN4base20string16_char_traitsESaItEERKNS_4FontEPiSA_i
>  }
>  {
> -   bug_70599
> -   Memcheck:Uninitialized
> -   fun:bcmp
> -   fun:_ZN3WTF14VectorComparerILb1EN7WebCore11CSSPropertyE*
> -   fun:_ZN3WTF20VectorTypeOperationsIN7WebCore11CSSPropertyE*
> -   fun:_ZN3WTFeqIN7WebCore11CSSPropertyE*
> -   fun:_ZNK7WebCore26CSSMutableStyleDeclaration15propertiesEqualEPKS0_
> -   fun:_ZNK7WebCore12NamedNodeMap20mappedMapsEquivalentEPKS0_
> -   fun:_ZNK7WebCore16CSSStyleSelector24canShareStyleWithElementE*
> -}
> -{
>     bug_71152
>     Memcheck:Leak
>     fun:_Znw*
> @@ -4144,16 +4126,6 @@
>     fun:_ZN12RenderWidget18OnHandleInputEventERKN3IPC7MessageE
>  }
>  {
> -   bug_107698
> -   Memcheck:Leak
> -   fun:malloc
> -   ...
> -
>
fun:_ZN7WebCore9CSSParser10parseSheetEPNS_13CSSStyleSheetERKN3WTF6StringEiPNS3_7HashMapIPNS_12CSSStyleRuleENS3_6RefPtrINS_17CSSRuleSourceDataEEENS3_7PtrHashIS9_EENS3_10HashTraitsIS9_EENSF_ISC_EEEE
> -   fun:_ZN7WebCore13CSSStyleSheet17parseStringAtLineERKN3WTF6StringEbi
> -   fun:_ZN7WebCore13CSSStyleSheet11parseStringERKN3WTF6StringEb
> -   fun:_ZN7WebCoreL12parseUASheetERKN3WTF6StringE
> -}
> -{
>     bug_107698a
>     Memcheck:Leak
>     fun:malloc
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[Eric Willigers, 2013-06-07 01:02:52]

108516,70599,107698 are each fixed.

[Timur Iskhodzhanov, 2013-06-07 09:30:48]

I'm a bit busy today, so deferring to Alexander.

[Alexander Potapenko, 2013-06-07 09:45:22]

LGTM

[commit-bot: I haz the power, 2013-06-07 11:30:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/16531003/1

[commit-bot: I haz the power, 2013-06-07 15:04:23]

Change committed as 204839