Issue 165309: Make double-clicking to select work correctly on Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165309: Make double-clicking to select work correctly on Mac.... (Closed)

Created:
11 years, 4 months ago by viettrungluu-gmail

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Make double-clicking to select work correctly on Mac. (I think that Linux uses an editor delegate -- see WebViewImpl::IsSelectTrailingWhitespaceEnabled() -- so it already works correctly; but if Linux ever stops, it'll now still work correctly also.) BUG=16624 TEST=Select some word on some web page by double-clicking on it; should select only the word and not any trailing space.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	webkit/glue/editor_client_impl.cc	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM. This matches the behavior in test_shell, which is why layout tests pass. And yes, ...

11 years, 4 months ago (2009-08-11 18:57:20 UTC) #1

viettrungluu-gmail

11 years, 4 months ago (2009-08-11 19:11:33 UTC) #3

On 2009/08/11 19:09:40, tony wrote:
> Landed in r23060.

Thanks, Tony.

Expand Messages | Collapse Messages