Devtools: expose scopes source location to debugger

src/ast/scopes.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_AST_SCOPES_H_
 #define V8_AST_SCOPES_H_
 
 #include "src/ast/ast.h"
 #include "src/hashmap.h"
 #include "src/pending-compilation-error-handler.h"
@@ skipping 538 matching lines @@
   // function objects (i.e., the scope for which a function prologue allocates
   // a context) or declaring temporaries.
   Scope* ClosureScope();
 
   // Find the first (non-arrow) function or script scope.  This is where
   // 'this' is bound, and what determines the function kind.
   Scope* ReceiverScope();
 
   Handle<ScopeInfo> GetScopeInfo(Isolate* isolate);
 
-  // Get the chain of nested scopes within this scope for the source statement
-  // position. The scopes will be added to the list from the outermost scope to
-  // the innermost scope. Only nested block, catch or with scopes are tracked
-  // and will be returned, but no inner function scopes.
-  void GetNestedScopeChain(Isolate* isolate, List<Handle<ScopeInfo> >* chain,

[sergeyv, 2016/02/25 20:45:55]

I'm not sure if this is a good idea to move it to debug-scopes.h, but now we
need scopes locations along with ScopeInfo. Looks like, to push location into
ScopeInfo isn't good way to go: it is especially compressed, while locations are
needed only by debugger.
I would be glad to hear better options.

[Yang, 2016/02/25 21:25:17]

ExtendedScopeInfo sgtm.

-                           int statement_position);
-
   void CollectNonLocals(HashMap* non_locals);
 
   // ---------------------------------------------------------------------------
   // Strict mode support.
   bool IsDeclared(const AstRawString* name) {
     // During formal parameter list parsing the scope only contains
     // two variables inserted at initialization: "this" and "arguments".
     // "this" is an invalid parameter name and "arguments" is invalid parameter
     // name in strict mode. Therefore looking up with the map which includes
     // "this" and "arguments" in addition to all formal parameters is safe.
@@ skipping 253 matching lines @@
   AstValueFactory* ast_value_factory_;
   Zone* zone_;
 
   PendingCompilationErrorHandler pending_error_handler_;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_AST_SCOPES_H_