Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 1653063002: Handle glTex{Sub}Image* calls with height==0. (Closed)

Created:
4 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 10 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle glTex{Sub}Image* calls with height==0. It is legal, and we have a bug handling such cases. BUG=582695 TEST=webgl_conformance (to be rolled in) R=vmiura@chromium.org Committed: https://crrev.com/cd81fc01b4fc01c843905ddc77beb452a6942d2c Cr-Commit-Position: refs/heads/master@{#373043}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653063002/1
4 years, 10 months ago (2016-02-01 18:57:07 UTC) #2
Zhenyao Mo
Victor: can you take a look? The test case is added to WebGL conformance here: ...
4 years, 10 months ago (2016-02-01 19:05:55 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-01 20:11:00 UTC) #5
vmiura
LGTM
4 years, 10 months ago (2016-02-02 19:09:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653063002/1
4 years, 10 months ago (2016-02-02 19:10:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 21:25:58 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 21:27:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd81fc01b4fc01c843905ddc77beb452a6942d2c
Cr-Commit-Position: refs/heads/master@{#373043}

Powered by Google App Engine
This is Rietveld 408576698