Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 1653053002: Devtools: parse variables scopes and sourcemap them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index b48706fb43e2ccfcd85609512b4b22b4a70400b6..7ef304958172e253b1d22a5ce0062aca2488c932 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -178,6 +178,16 @@ WebInspector.RemoteObject.prototype = {
},
/**
+ * @param {string|!RuntimeAgent.CallArgument} name
+ * @param {string} value
+ * @param {function(string=)} callback
+ */
+ setPropertyValue: function(name, value, callback)
+ {
+ throw "Not implemented";
+ },
+
+ /**
* @param {function(this:Object, ...)} functionDeclaration
* @param {!Array<!RuntimeAgent.CallArgument>=} args
* @param {function(?WebInspector.RemoteObject, boolean=)=} callback
@@ -707,6 +717,7 @@ WebInspector.RemoteObjectImpl.prototype = {
},
/**
+ * @override
* @param {string|!RuntimeAgent.CallArgument} name
* @param {string} value
* @param {function(string=)} callback
@@ -1051,12 +1062,13 @@ WebInspector.ScopeRemoteObject.prototype = {
/**
* @override
* @param {!RuntimeAgent.RemoteObject} result
- * @param {!RuntimeAgent.CallArgument} name
+ * @param {!RuntimeAgent.CallArgument} argumentName
* @param {function(string=)} callback
*/
- doSetObjectPropertyValue: function(result, name, callback)
+ doSetObjectPropertyValue: function(result, argumentName, callback)
{
- this._debuggerModel.setVariableValue(this._scopeRef.number, /** @type {string} */ (name.value), WebInspector.RemoteObject.toCallArgument(result), this._scopeRef.callFrameId, this._scopeRef.functionId, setVariableValueCallback.bind(this));
+ var name = /** @type {string} */ (argumentName.value);
+ this._debuggerModel.setVariableValue(this._scopeRef.number, name, WebInspector.RemoteObject.toCallArgument(result), this._scopeRef.callFrameId, this._scopeRef.functionId, setVariableValueCallback.bind(this));
/**
* @param {string=} error

Powered by Google App Engine
This is Rietveld 408576698