third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js - Issue 1653053002: Devtools: parse variables scopes and sourcemap them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 1653053002: Devtools: parse variables scopes and sourcemap them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js ('K') | « third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js ('k') | third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js » ('j') | third_party/WebKit/Source/devtools/front_end/sources/module.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

index 4841b8bd2552e87c53e75ba3fa6bc9ab2cdc627d..46ee7f9003f34543898cfdbabe007cc9a61d0dab 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

@@ -712,7 +712,7 @@ WebInspector.JavaScriptSourceFrame.prototype = {

var localScope = callFrame.localScope();

var functionLocation = callFrame.functionLocation();

if (localScope && functionLocation)

- localScope.object().getAllProperties(false, this._prepareScopeVariables.bind(this, callFrame));

+ WebInspector.sourceMapNamesResolver.resolveScopeInObject(localScope).getAllProperties(false, this._prepareScopeVariables.bind(this, callFrame));

dgozman 2016/02/22 17:24:56 Can we avoid global singleton?

sergeyv 2016/02/22 21:42:54 Done. Made static function

if (this._clearValueWidgetsTimer) {

clearTimeout(this._clearValueWidgetsTimer);