Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1653043002: Remove Sparse Histograms from Blink Platform API. (Closed)

Created:
4 years, 10 months ago by dtapuska
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eae+blinkwatch, Eric Willigers, jam, rjwright, rwlbuis, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_blink_histograms
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Sparse Histograms from Blink Platform API. Use the newly created API (in https://codereview.chromium.org/1647883004/) to create sparse histograms and remove the API from the blink platform. BUG=583012 Committed: https://crrev.com/5119494478729af6b78cc4525136a4422acadf3b Cr-Commit-Position: refs/heads/master@{#372830}

Patch Set 1 #

Patch Set 2 : Fix android code path #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -15 lines) Patch
M content/child/blink_platform_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/blink_platform_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 3 chunks +6 lines, -2 lines 1 comment Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
dtapuska
4 years, 10 months ago (2016-02-01 18:50:48 UTC) #3
Charlie Reis
content/ LGTM.
4 years, 10 months ago (2016-02-01 21:24:40 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/1653043002/diff/20001/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/1653043002/diff/20001/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp#newcode497 third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp:497: propertyHistogram.sample(UseCounter::mapCSSPropertyIdToCSSSampleIdForHistogram(id)); Perhaps there should be a macro that wraps ...
4 years, 10 months ago (2016-02-01 21:30:31 UTC) #6
esprehn
On 2016/02/01 at 21:30:31, asvitkine wrote: > https://codereview.chromium.org/1653043002/diff/20001/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp > File third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp (right): > > https://codereview.chromium.org/1653043002/diff/20001/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp#newcode497 ...
4 years, 10 months ago (2016-02-01 23:49:27 UTC) #7
esprehn
lgtm
4 years, 10 months ago (2016-02-01 23:49:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653043002/20001
4 years, 10 months ago (2016-02-01 23:52:50 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 00:21:42 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 00:22:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5119494478729af6b78cc4525136a4422acadf3b
Cr-Commit-Position: refs/heads/master@{#372830}

Powered by Google App Engine
This is Rietveld 408576698