Issue 1653023004: Merge to XFA: Remove the m_ObjVersion member variable from CPDF_Parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1653023004: Merge to XFA: Remove the m_ObjVersion member variable from CPDF_Parser. (Closed)

Created:
4 years, 10 months ago by Lei Zhang

Modified:
4 years, 10 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove the m_ObjVersion member variable from CPDF_Parser. Use the gennum field in the m_ObjectInfo map instead. BUG=pdfium:111 R=weili@chromium.org TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1654303002 . (cherry picked from commit a620372c9e1d0ff825bcbe6620fe7e1b63c769c2) Committed: https://pdfium.googlesource.com/pdfium/+/05797682103f8c724bc21fa197ee6f9f6515081e

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -29 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	7 chunks	+8 lines, -8 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View	2 chunks	+2 lines, -16 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

4 years, 10 months ago (2016-02-01 22:52:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
05797682103f8c724bc21fa197ee6f9f6515081e (presubmit successful).