chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc - Issue 1653013002: Abstract ToolbarModelImpl dependencies on //content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

Issue 1653013002: Abstract ToolbarModelImpl dependencies on //content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1

Patch Set: Address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

diff --git a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

index ab627c3408631e2f96c8366db8c70169a4eb3e3f..8d8b067890172c94a150d5b92d4cf7fe4a515ead 100644

--- a/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

+++ b/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc

@@ -29,6 +29,7 @@

#include "content/public/browser/navigation_controller.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/common/content_constants.h"

#include "grit/components_strings.h"

#include "ipc/ipc_message.h"

#include "ui/base/l10n/l10n_util.h"

@@ -166,7 +167,8 @@ void SimpleWebViewDialog::Init() {

if (web_view_->GetWebContents())

ChromeSecurityStateModelClient::CreateForWebContents(

web_view_->GetWebContents());

- toolbar_model_.reset(new ToolbarModelImpl(this));

+ toolbar_model_.reset(

+ new ToolbarModelImpl(this, content::kMaxURLDisplayChars));

set_background(views::Background::CreateSolidBackground(kDialogColor));