Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: components/BUILD.gn

Issue 1653003006: Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/BUILD.gn ('k') | components/nacl/loader/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/BUILD.gn
diff --git a/components/BUILD.gn b/components/BUILD.gn
index 4a6c87dbe6fde5f062406fda1cdbd4b39c57d375..63c8ed391ce65f0b3729baf94c346c5bf06232e8 100644
--- a/components/BUILD.gn
+++ b/components/BUILD.gn
@@ -12,15 +12,6 @@ if (is_android) {
import("//build/config/android/rules.gni")
}
-# TODO(GYP): Delete this after we've converted everything to GN.
-# The _run targets exist only for compatibility w/ GYP.
-group("components_unittests_run") {
- testonly = true
- deps = [
- ":components_unittests",
- ]
-}
-
# To add a unit test to this target, make a "unit_test" source_set in your
# component (it's important to use a source_set instead of a static library or
# no tests will run) and add a reference here. You can add more than one unit
@@ -326,15 +317,6 @@ if (is_android) {
}
}
-# TODO(GYP): Delete this after we've converted everything to GN.
-# The _run targets exist only for compatibility w/ GYP.
-group("components_browsertests_run") {
- testonly = true
- deps = [
- ":components_browsertests",
- ]
-}
-
test("components_browsertests") {
sources = []
defines = [ "HAS_OUT_OF_PROC_TEST_RUNNER" ]
« no previous file with comments | « chrome/test/chromedriver/BUILD.gn ('k') | components/nacl/loader/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698