Precompilation: canonicalize Instructions in PRODUCT mode.

Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/9f751862db30a649c4ab0b04cdd9d4aa79409ce8

[rmacnak, 2016-02-04 17:37:51]

Description was changed from

==========
Precompilation: canonicalize Instructions.

Destroys profiler results; to be added to deploy mode only.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)
==========

to

==========
Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)
==========

[rmacnak, 2016-02-04 17:39:20]

Description was changed from

==========
Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)
==========

to

==========
Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)
==========

[rmacnak, 2016-02-04 17:44:19]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, iposva@google.com

[Ivan Posva, 2016-02-04 18:00:03]

Thanks,
-Ivan

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:132: #if defined(PRODUCT)
Please use a release flag to control this. This will allow for easier testing
and development.

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1213: instructions_ =
DedupInstructions(instructions_);
This function is a bit unfortunately named due to it being a duplicate name.

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1227: return set_instructions->raw();
cached_instructions?

[rmacnak, 2016-02-04 19:29:47]

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler.cc
File runtime/vm/precompiler.cc (right):

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:132: #if defined(PRODUCT)
On 2016/02/04 18:00:03, Ivan Posva wrote:
> Please use a release flag to control this. This will allow for easier testing
> and development.

Done.

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1213: instructions_ =
DedupInstructions(instructions_);
On 2016/02/04 18:00:03, Ivan Posva wrote:
> This function is a bit unfortunately named due to it being a duplicate name.

Changed to DedupOneInstructions

https://codereview.chromium.org/1653003003/diff/20001/runtime/vm/precompiler....
runtime/vm/precompiler.cc:1227: return set_instructions->raw();
On 2016/02/04 18:00:03, Ivan Posva wrote:
> cached_instructions?

Changed to canonical_instructions_ and changed canonical_instructions_ to
canoncial_instructions_set_.

[Florian Schneider, 2016-02-08 06:30:17]

lgtm

[rmacnak, 2016-02-08 19:28:00]

Description was changed from

==========
Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)
==========

to

==========
Precompilation: canonicalize Instructions in PRODUCT mode.

precompiled dart2js x64 21550906 -> 18787632 (-12.8%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9f751862db30a649c4ab0b04cdd9d4aa79409ce8
==========

[rmacnak, 2016-02-08 19:28:01]

Committed patchset #3 (id:40001) manually as
9f751862db30a649c4ab0b04cdd9d4aa79409ce8 (presubmit successful).