add function to test whether string contents are definitely one byte

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4286 matching lines @@
 
 bool String::IsOneByte() const {
   i::Handle<i::String> str = Utils::OpenHandle(this);
   if (IsDeadCheck(str->GetIsolate(), "v8::String::IsOneByte()")) {
     return false;
   }
   return str->HasOnlyOneByteChars();
 }
 
 
+class DefinitelyContainsOnlyOneByteHelper {
+ public:
+  DefinitelyContainsOnlyOneByteHelper() : is_one_byte_(true) {}
+  bool Check(i::String* string) {
+    i::ConsString* cons_string = i::String::VisitFlat(this, string, 0);
+    if (cons_string == NULL) return is_one_byte_;
+    return CheckCons(cons_string);
+  }
+  void VisitOneByteString(const uint8_t* chars, int length) {
+    // Nothing to do.
+  }
+  void VisitTwoByteString(const uint16_t* chars, int length) {
+    for (int i = 0; i < length; i++) {
+      if (chars[i] >> 8) {
+        is_one_byte_ = false;
+        return;
+      }
+    }
+  }
+
+ private:
+  bool CheckCons(i::ConsString* cons_string) {
+    while (true) {
+      // Check left side if flat.
+      i::String* left = cons_string->first();
+      i::ConsString* left_as_cons =
+          i::String::VisitFlat(this, left, 0);
+      if (!is_one_byte_) return false;
+      // Check right side if flat.
+      i::String* right = cons_string->second();
+      i::ConsString* right_as_cons =
+          i::String::VisitFlat(this, right, 0);
+      if (!is_one_byte_) return false;
+      // Standard recurse/iterate trick.
+      // Falls through to the cases below for the iteration.
+      if (left_as_cons != NULL && right_as_cons != NULL) {
+        if (left->length() < right->length()) {
+          CheckCons(right_as_cons);
+          right_as_cons = NULL;

[Yang, 2013/06/06 09:12:59]

I think it's a bit easier to read if you just set cons_string at this point and
continue instead of falling through.

And isn't the recurse/iterate trick recursing over the shorter string and
iterating over the longer one, to reduce recursion depth? Example: maximally
unbalanced tree.

[dcarney, 2013/06/06 09:17:26]

okay
yes. this is why we have code reviews

+        } else {
+          CheckCons(left_as_cons);
+          left_as_cons = NULL;
+        }
+        // Check fast return.
+        if (!is_one_byte_) return false;
+      }
+      // Descend left in place.
+      if (left_as_cons != NULL) {
+        cons_string = left_as_cons;
+        continue;
+      }
+      // Descend right in place.
+      if (right_as_cons != NULL) {
+        cons_string = right_as_cons;
+        continue;
+      }
+      // Terminate.
+      break;
+    }
+    return is_one_byte_;
+  }
+  bool is_one_byte_;
+  DISALLOW_COPY_AND_ASSIGN(DefinitelyContainsOnlyOneByteHelper);
+};
+
+
+bool String::DefinitelyContainsOnlyOneByte() const {
+  i::Handle<i::String> str = Utils::OpenHandle(this);
+  if (IsDeadCheck(str->GetIsolate(),
+                  "v8::String::DefinitelyContainsOnlyOneByte()")) {
+    return false;
+  }
+  if (str->HasOnlyOneByteChars()) return true;
+  DefinitelyContainsOnlyOneByteHelper helper;
+  return helper.Check(*str);

[Yang, 2013/06/06 09:12:59]

If we find that the string only contains one byte chars, we could change the map
so that HasOnlyOneByteChars() returns true.

[dcarney, 2013/06/06 09:17:26]

will do

+}
+
+
 class Utf8LengthHelper : public i::AllStatic {
  public:
   enum State {
     kEndsWithLeadingSurrogate = 1 << 0,
     kStartsWithTrailingSurrogate = 1 << 1,
     kLeftmostEdgeIsCalculated = 1 << 2,
     kRightmostEdgeIsCalculated = 1 << 3,
     kLeftmostEdgeIsSurrogate = 1 << 4,
     kRightmostEdgeIsSurrogate = 1 << 5
   };
@@ skipping 3538 matching lines @@
 
   v->VisitPointers(blocks_.first(), first_block_limit_);
 
   for (int i = 1; i < blocks_.length(); i++) {
     v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
   }
 }
 
 
 } }  // namespace v8::internal