third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Apply similar changes from custom count histograms change to this change Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/UseCounter.cpp ('K') | « third_party/WebKit/Source/core/frame/VisualViewport.cpp ('k') | third_party/WebKit/Source/core/html/HTMLLinkElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

index f0c2f5bb0e85aca9b5f2d33dc1db886b48a4252b..c10da492c84e4e70cee5d370d6e68027447876f7 100644

--- a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp

@@ -46,6 +46,7 @@

#include "core/imagebitmap/ImageBitmapOptions.h"

#include "core/layout/LayoutHTMLCanvas.h"

#include "core/paint/PaintLayer.h"

+#include "platform/Histogram.h"

#include "platform/MIMETypeRegistry.h"

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/graphics/Canvas2DImageBufferSurface.h"

@@ -237,8 +238,10 @@ CanvasRenderingContext* HTMLCanvasElement::getCanvasRenderingContext(const Strin

return nullptr;

// Log the aliased context type used.

- if (!m_context)

- Platform::current()->histogramEnumeration("Canvas.ContextType", contextType, CanvasRenderingContext::ContextTypeCount);

+ if (!m_context) {

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, contextTypeHistogram, ("Canvas.ContextType", CanvasRenderingContext::ContextTypeCount));

+ contextTypeHistogram.count(contextType);

+ }

contextType = CanvasRenderingContext::resolveContextTypeAliases(contextType);