third_party/WebKit/Source/core/css/FontFaceSet.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFaceSet.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Fix misplaced bracket on android Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/FontFace.cpp ('k') | third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFaceSet.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFaceSet.cpp b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

index 89890bfdb72cef4a6605cb263d73c184ede15341..1b90a32d9c6d941776c626ce33abfc5d01e668cf 100644

--- a/third_party/WebKit/Source/core/css/FontFaceSet.cpp

+++ b/third_party/WebKit/Source/core/css/FontFaceSet.cpp

@@ -41,7 +41,6 @@

#include "core/frame/LocalFrame.h"

#include "core/style/StyleInheritedData.h"

#include "platform/Histogram.h"

-#include "public/platform/Platform.h"

namespace blink {

@@ -484,7 +483,8 @@ void FontFaceSet::FontLoadHistogram::record()

webFontsInPageHistogram.count(m_count);

}

if (m_status == HadBlankText || m_status == DidNotHaveBlankText) {

- Platform::current()->histogramEnumeration("WebFont.HadBlankText", m_status == HadBlankText ? 1 : 0, 2);

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, hadBlankTextHistogram, new EnumerationHistogram("WebFont.HadBlankText", 2));

+ hadBlankTextHistogram.count(m_status == HadBlankText ? 1 : 0);

m_status = Reported;

}