Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/web/WebPageImportanceSignals.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a
Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "public/web/WebPageImportanceSignals.h" 5 #include "public/web/WebPageImportanceSignals.h"
6 6
7 #include "public/platform/Platform.h" 7 #include "platform/Histogram.h"
8 #include "public/web/WebViewClient.h" 8 #include "public/web/WebViewClient.h"
9 9
10 namespace blink { 10 namespace blink {
11 11
12 void WebPageImportanceSignals::reset() 12 void WebPageImportanceSignals::reset()
13 { 13 {
14 m_hadFormInteraction = false; 14 m_hadFormInteraction = false;
15 m_issuedNonGetFetchFromScript = false; 15 m_issuedNonGetFetchFromScript = false;
16 if (m_observer) 16 if (m_observer)
17 m_observer->pageImportanceSignalsChanged(); 17 m_observer->pageImportanceSignalsChanged();
18 } 18 }
19 19
20 void WebPageImportanceSignals::setHadFormInteraction() 20 void WebPageImportanceSignals::setHadFormInteraction()
21 { 21 {
22 m_hadFormInteraction = true; 22 m_hadFormInteraction = true;
23 if (m_observer) 23 if (m_observer)
24 m_observer->pageImportanceSignalsChanged(); 24 m_observer->pageImportanceSignalsChanged();
25 } 25 }
26 26
27 void WebPageImportanceSignals::setIssuedNonGetFetchFromScript() 27 void WebPageImportanceSignals::setIssuedNonGetFetchFromScript()
28 { 28 {
29 m_issuedNonGetFetchFromScript = true; 29 m_issuedNonGetFetchFromScript = true;
30 if (m_observer) 30 if (m_observer)
31 m_observer->pageImportanceSignalsChanged(); 31 m_observer->pageImportanceSignalsChanged();
32 } 32 }
33 33
34 void WebPageImportanceSignals::onCommitLoad() 34 void WebPageImportanceSignals::onCommitLoad()
35 { 35 {
36 Platform::current()->histogramEnumeration("PageImportanceSignals.HadFormInte raction.OnCommitLoad", m_hadFormInteraction, 2); 36 DEFINE_STATIC_LOCAL(EnumerationHistogram, hadFormInteractionHistogram, ("Pag eImportanceSignals.HadFormInteraction.OnCommitLoad", 2));
37 Platform::current()->histogramEnumeration("PageImportanceSignals.IssuedNonGe tFetchFromScript.OnCommitLoad", m_issuedNonGetFetchFromScript, 2); 37 hadFormInteractionHistogram.count(m_hadFormInteraction);
38
39 DEFINE_STATIC_LOCAL(EnumerationHistogram, issuedNonGetHistogram, ("PageImpor tanceSignals.IssuedNonGetFetchFromScript.OnCommitLoad", 2));
40 issuedNonGetHistogram.count(m_issuedNonGetFetchFromScript);
38 41
39 reset(); 42 reset();
40 } 43 }
41 44
42 } // namespace blink 45 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698