Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a
Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 16 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY 17 * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 18 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 19 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND 20 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "platform/graphics/Canvas2DLayerBridge.h" 26 #include "platform/graphics/Canvas2DLayerBridge.h"
27 27
28 #include "platform/Histogram.h"
28 #include "platform/TraceEvent.h" 29 #include "platform/TraceEvent.h"
29 #include "platform/graphics/CanvasMetrics.h" 30 #include "platform/graphics/CanvasMetrics.h"
30 #include "platform/graphics/ExpensiveCanvasHeuristicParameters.h" 31 #include "platform/graphics/ExpensiveCanvasHeuristicParameters.h"
31 #include "platform/graphics/GraphicsLayer.h" 32 #include "platform/graphics/GraphicsLayer.h"
32 #include "platform/graphics/ImageBuffer.h" 33 #include "platform/graphics/ImageBuffer.h"
33 #include "platform/graphics/gpu/SharedContextRateLimiter.h" 34 #include "platform/graphics/gpu/SharedContextRateLimiter.h"
34 #include "public/platform/Platform.h" 35 #include "public/platform/Platform.h"
35 #include "public/platform/WebCompositorSupport.h" 36 #include "public/platform/WebCompositorSupport.h"
36 #include "public/platform/WebGraphicsContext3D.h" 37 #include "public/platform/WebGraphicsContext3D.h"
37 #include "public/platform/WebGraphicsContext3DProvider.h" 38 #include "public/platform/WebGraphicsContext3DProvider.h"
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 // that significantly helps a number of use cases. The rationale is that if 339 // that significantly helps a number of use cases. The rationale is that if
339 // immediate rendering was needed once, it is likely to be needed at least 340 // immediate rendering was needed once, it is likely to be needed at least
340 // once per frame, which eliminates the possibility for inter-frame 341 // once per frame, which eliminates the possibility for inter-frame
341 // overdraw optimization. Furthermore, in cases where immediate mode is 342 // overdraw optimization. Furthermore, in cases where immediate mode is
342 // required multiple times per frame, the repeated flushing of deferred 343 // required multiple times per frame, the repeated flushing of deferred
343 // commands would cause significant overhead, so it is better to just stop 344 // commands would cause significant overhead, so it is better to just stop
344 // trying to defer altogether. 345 // trying to defer altogether.
345 if (!m_isDeferralEnabled) 346 if (!m_isDeferralEnabled)
346 return; 347 return;
347 348
348 Platform::current()->histogramEnumeration("Canvas.GPUAccelerated2DCanvasDisa bleDeferralReason", reason, DisableDeferralReasonCount); 349 DEFINE_STATIC_LOCAL(EnumerationHistogram, gpuDisabledHistogram, ("Canvas.GPU Accelerated2DCanvasDisableDeferralReason", DisableDeferralReasonCount));
350 gpuDisabledHistogram.count(reason);
349 CanvasMetrics::countCanvasContextUsage(CanvasMetrics::GPUAccelerated2DCanvas DeferralDisabled); 351 CanvasMetrics::countCanvasContextUsage(CanvasMetrics::GPUAccelerated2DCanvas DeferralDisabled);
350 flushRecordingOnly(); 352 flushRecordingOnly();
351 // Because we will be discarding the recorder, if the flush failed 353 // Because we will be discarding the recorder, if the flush failed
352 // content will be lost -> force m_haveRecordedDrawCommands to false 354 // content will be lost -> force m_haveRecordedDrawCommands to false
353 m_haveRecordedDrawCommands = false; 355 m_haveRecordedDrawCommands = false;
354 356
355 m_isDeferralEnabled = false; 357 m_isDeferralEnabled = false;
356 m_recorder.clear(); 358 m_recorder.clear();
357 // install the current matrix/clip stack onto the immediate canvas 359 // install the current matrix/clip stack onto the immediate canvas
358 SkSurface* surface = getOrCreateSurface(); 360 SkSurface* surface = getOrCreateSurface();
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
818 820
819 Canvas2DLayerBridge::MailboxInfo::MailboxInfo(const MailboxInfo& other) 821 Canvas2DLayerBridge::MailboxInfo::MailboxInfo(const MailboxInfo& other)
820 { 822 {
821 memcpy(&m_mailbox, &other.m_mailbox, sizeof(m_mailbox)); 823 memcpy(&m_mailbox, &other.m_mailbox, sizeof(m_mailbox));
822 m_image = other.m_image; 824 m_image = other.m_image;
823 m_parentLayerBridge = other.m_parentLayerBridge; 825 m_parentLayerBridge = other.m_parentLayerBridge;
824 } 826 }
825 827
826 void Canvas2DLayerBridge::Logger::reportHibernationEvent(HibernationEvent event) 828 void Canvas2DLayerBridge::Logger::reportHibernationEvent(HibernationEvent event)
827 { 829 {
828 blink::Platform::current()->histogramEnumeration("Canvas.HibernationEvents", event, HibernationEventCount); 830 DEFINE_STATIC_LOCAL(EnumerationHistogram, hibernationHistogram, ("Canvas.Hib ernationEvents", HibernationEventCount));
831 hibernationHistogram.count(event);
829 } 832 }
830 833
831 } // namespace blink 834 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698