Switch to using Function(Any) for foreign functions, label declarations.

Switch to using Function(Any) for foreign functions, label declarations.

As it turns out checking for bare Type::Function is problematic,
switching to use Type::Function(Type::Any())).

Also labeling the type on foreign function declarations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400
Cr-Commit-Position: refs/heads/master@{#33691}

[bradn, 2016-02-01 23:45:01]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[aseemgarg, 2016-02-02 00:52:35]

lgtm

[bradn, 2016-02-02 01:16:26]

The CQ bit was checked by bradnelson@google.com

[commit-bot: I haz the power, 2016-02-02 01:16:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652963004/1

[commit-bot: I haz the power, 2016-02-02 01:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 01:18:44]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10391)

[bradnelson, 2016-02-02 21:22:37]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-02-02 21:23:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652963004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652963004/1

[commit-bot: I haz the power, 2016-02-02 21:25:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 21:25:54]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10447)

[bradnelson, 2016-02-03 00:14:42]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-02-03 00:14:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
aseemgarg@chromium.org
Link to the patchset: https://codereview.chromium.org/1652963004/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2016-02-03 00:15:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1652963004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1652963004/20001

[commit-bot: I haz the power, 2016-02-03 01:20:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-03 01:21:10]

Description was changed from

==========
Switch to using Function(Any) for foreign functions, label declarations.

As it turns out checking for bare Type::Function is problematic,
switching to use Type::Function(Type::Any())).

Also labeling the type on foreign function declarations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org
LOG=N
==========

to

==========
Switch to using Function(Any) for foreign functions, label declarations.

As it turns out checking for bare Type::Function is problematic,
switching to use Type::Function(Type::Any())).

Also labeling the type on foreign function declarations.

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=test-asm-validator
R=aseemgarg@chromium.org
LOG=N

Committed: https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400
Cr-Commit-Position: refs/heads/master@{#33691}
==========

[commit-bot: I haz the power, 2016-02-03 01:21:11]

Patchset 2 (id:??) landed as
https://crrev.com/da632baac7e28d370d9893676c8d1d3e901a4400
Cr-Commit-Position: refs/heads/master@{#33691}

[brucedawson, 2016-02-05 23:35:50]

brucedawson@chromium.org changed reviewers:
+ brucedawson@chromium.org

[brucedawson, 2016-02-05 23:35:51]

https://codereview.chromium.org/1652963004/diff/20001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1652963004/diff/20001/src/typing-asm.cc#newco...
src/typing-asm.cc:950: ZoneList<Expression*>* args = expr->arguments();
Not a serious problem, but this line of code is redundant. It makes the same
call and assigns to an identically named/typed variable as the line of code
three lines above.

The /analyze builder noticed this. Some day I'll turn on variable shadowing
warnings in normal builds...

[bradn, 2016-02-06 00:32:54]

https://codereview.chromium.org/1652963004/diff/20001/src/typing-asm.cc
File src/typing-asm.cc (right):

https://codereview.chromium.org/1652963004/diff/20001/src/typing-asm.cc#newco...
src/typing-asm.cc:950: ZoneList<Expression*>* args = expr->arguments();
On 2016/02/05 23:35:50, brucedawson wrote:
> Not a serious problem, but this line of code is redundant. It makes the same
> call and assigns to an identically named/typed variable as the line of code
> three lines above.
> 
> The /analyze builder noticed this. Some day I'll turn on variable shadowing
> warnings in normal builds...

Ah, bad merge.
Thanks!