Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: third_party/WebKit/Source/core/css/CSSFontSelector.cpp

Issue 1652953002: Make copyToVector() robust against conservative GCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove unnecessary 'template' use Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/HashCountedSet.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSFontSelector.cpp
diff --git a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
index 1719ae944ed8620057dc18ebeee729455083a8b1..7c432eba6f6e4063162d05bbc42e826aa3e7ff5b 100644
--- a/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
+++ b/third_party/WebKit/Source/core/css/CSSFontSelector.cpp
@@ -83,12 +83,8 @@ void CSSFontSelector::dispatchInvalidationCallbacks()
WillBeHeapVector<RawPtrWillBeMember<CSSFontSelectorClient>> clients;
copyToVector(m_clients, clients);
- // TODO(sof): the null check is temporarily in place to speculatively address
- // crbug.com/568173.
- for (auto& client : clients) {
- if (client)
- client->fontsNeedUpdate(this);
- }
+ for (auto& client : clients)
+ client->fontsNeedUpdate(this);
}
void CSSFontSelector::fontFaceInvalidated()
« no previous file with comments | « no previous file | third_party/WebKit/Source/wtf/HashCountedSet.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698