chrome/browser/download/download_exe.cc - Issue 165295: Add "dangerous download" view on OS X, for now for dmg files. Also fix download item layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_exe.cc

Issue 165295: Add "dangerous download" view on OS X, for now for dmg files. Also fix download item layout. (Closed)

Patch Set: Address comments Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_exe.cc

diff --git a/chrome/browser/download/download_exe.cc b/chrome/browser/download/download_exe.cc

index 2663b541961a19848b9754aedfab22b995c49889..39a14f7638611d699e58449d9868a476ea215fc9 100644

--- a/chrome/browser/download/download_exe.cc

+++ b/chrome/browser/download/download_exe.cc

@@ -145,7 +145,10 @@ static const char* const g_executables[] = {

"py",

"rb",

"sh",

-#endif // defined(OS_LINUX)

+#elif defined(OS_MACOSX)

+ // TODO(thakis): Figure out what makes sense here -- crbug.com/19096

+ "dmg",

+#endif

};

void InitializeExeTypes(std::set<std::string>* exe_extensions) {