Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1652943002: SkPictureShader cleanup (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M src/core/SkPictureShader.cpp View 3 chunks +3 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
f(malita)
As suggested in https://codereview.chromium.org/1405103003/#msg13, we can fold the generator and image allocation into one SkImage::NewFromPicture ...
4 years, 10 months ago (2016-02-01 13:18:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652943002/1
4 years, 10 months ago (2016-02-01 13:19:11 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-01 13:34:19 UTC) #6
reed1
lgtm
4 years, 10 months ago (2016-02-01 16:31:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652943002/1
4 years, 10 months ago (2016-02-01 17:19:14 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 17:19:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/40bed64ff0f2dc842f01a0e8ad85c0cec9fab4b5

Powered by Google App Engine
This is Rietveld 408576698