Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: remoting/host/token_validator_base.h

Issue 165293004: Refactor TokenValidatorImpl into a base class + implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/remoting_me2me_host.cc ('k') | remoting/host/token_validator_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/token_validator_base.h
diff --git a/remoting/host/token_validator_base.h b/remoting/host/token_validator_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..cd73afa515e54a4642cbfe78ebba8a187c1fe381
--- /dev/null
+++ b/remoting/host/token_validator_base.h
@@ -0,0 +1,90 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_TOKEN_VALIDATOR_BASE_H_
+#define REMOTING_HOST_TOKEN_VALIDATOR_BASE_H_
+
+#include "base/callback.h"
+#include "base/memory/weak_ptr.h"
+#include "net/url_request/url_request.h"
+#include "net/url_request/url_request_context_getter.h"
+#include "remoting/protocol/token_validator.h"
+#include "url/gurl.h"
+
+namespace net {
+class ClientCertStore;
+typedef std::vector<scoped_refptr<X509Certificate> > CertificateList;
+}
+
+namespace remoting {
+
+struct ThirdPartyAuthConfig {
+ inline bool is_empty() const {
+ return token_url.is_empty() && token_validation_url.is_empty();
+ }
+
+ inline bool is_valid() const {
+ return token_url.is_valid() && token_validation_url.is_valid();
+ }
+
+ GURL token_url;
+ GURL token_validation_url;
+ std::string token_validation_cert_issuer;
+};
+
+class TokenValidatorBase
+ : public net::URLRequest::Delegate,
+ public protocol::TokenValidator {
+ public:
+ TokenValidatorBase(
+ const ThirdPartyAuthConfig& third_party_auth_config,
+ const std::string& token_scope,
+ scoped_refptr<net::URLRequestContextGetter> request_context_getter);
+ virtual ~TokenValidatorBase();
+
+ // TokenValidator interface.
+ virtual void ValidateThirdPartyToken(
+ const std::string& token,
+ const base::Callback<void(
+ const std::string& shared_secret)>& on_token_validated) OVERRIDE;
+
+ virtual const GURL& token_url() const OVERRIDE;
+ virtual const std::string& token_scope() const OVERRIDE;
+
+ // URLRequest::Delegate interface.
+ virtual void OnResponseStarted(net::URLRequest* source) OVERRIDE;
+ virtual void OnReadCompleted(net::URLRequest* source,
+ int bytes_read) OVERRIDE;
+ virtual void OnCertificateRequested(
+ net::URLRequest* source,
+ net::SSLCertRequestInfo* cert_request_info) OVERRIDE;
+
+ protected:
+ void OnCertificatesSelected(net::CertificateList* selected_certs,
+ net::ClientCertStore* unused);
+
+ virtual void StartValidateRequest(const std::string& token) = 0;
+ virtual bool IsValidScope(const std::string& token_scope);
+ std::string ProcessResponse();
+
+ // Constructor parameters.
+ ThirdPartyAuthConfig third_party_auth_config_;
+ std::string token_scope_;
+ scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
+
+ // URLRequest related fields.
+ scoped_ptr<net::URLRequest> request_;
+ scoped_refptr<net::IOBuffer> buffer_;
+ std::string data_;
+
+ base::Callback<void(const std::string& shared_secret)> on_token_validated_;
+
+ base::WeakPtrFactory<TokenValidatorBase> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(TokenValidatorBase);
+};
+
+} // namespace remoting
+
+#endif // REMOTING_HOST_TOKEN_VALIDATOR_BASE_H
« no previous file with comments | « remoting/host/remoting_me2me_host.cc ('k') | remoting/host/token_validator_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698