Issue 1652923002: dart2js cps: Update status file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1652923002: dart2js cps: Update status file. (Closed)

Created:
4 years, 10 months ago by asgerf

Modified:
4 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

dart2js cps: Update status file. BUG= Committed: https://github.com/dart-lang/sdk/commit/27bb7d615382edf73517eb81b1834308bc7a1257

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tests/co19/co19-dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/language/language_dart2js.status	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

asgerf

Committed patchset #1 (id:1) manually as 27bb7d615382edf73517eb81b1834308bc7a1257 (presubmit successful).

4 years, 10 months ago (2016-02-01 12:28:33 UTC) #4

asgerf

4 years, 10 months ago (2016-02-01 13:01:52 UTC) #6

Message was sent while issue was closed.

On 2016/02/01 12:48:36, Johnni Winther wrote:
> LGTM
> 
> Do we track these crashes with a bug?

No, but this one is pretty common so I opened one now
(https://github.com/dart-lang/sdk/issues/25635).

Note that the comments in the status file are generated by a tool, based on the
error message thrown by the test.  We can't always link it to an issue based on
the error message alone, so for the most part, the message is just there to help
with triaging and understanding why a status line is there.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages