Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6798)

Unified Diff: chrome/chrome.gyp

Issue 165290: Set Mac creator signature to 'rimZ' (Google Chrome) and 'Cr24' (Chromium) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 23010)
+++ chrome/chrome.gyp (working copy)
@@ -70,9 +70,11 @@
['OS=="mac"', {
'conditions': [
['branding=="Chrome"', {
- 'bundle_id': 'com.google.Chrome',
+ 'mac_bundle_id': 'com.google.Chrome',
+ 'mac_creator': 'rimZ',
}, { # else: branding!="Chrome"
- 'bundle_id': 'org.chromium.Chromium',
+ 'mac_bundle_id': 'org.chromium.Chromium',
+ 'mac_creator': 'Cr24',
}], # branding
], # conditions
}], # OS=="mac"
@@ -3091,7 +3093,8 @@
# CFBundleName of CHROMIUM_SHORT_NAME
# Xcode then replaces these values with the branded values we set
# as settings on the target.
- 'CHROMIUM_BUNDLE_ID': '<(bundle_id)',
+ 'CHROMIUM_BUNDLE_ID': '<(mac_bundle_id)',
+ 'CHROMIUM_CREATOR': '<(mac_creator)',
'CHROMIUM_SHORT_NAME': '<(branding)',
},
'mac_bundle_resources': [
@@ -4515,7 +4518,7 @@
['exclude', '.*'],
],
'xcode_settings': {
- 'CHROMIUM_BUNDLE_ID': '<(bundle_id)',
+ 'CHROMIUM_BUNDLE_ID': '<(mac_bundle_id)',
'CHROMIUM_SHORT_NAME': '<(branding)',
'INFOPLIST_FILE': 'app/helper-Info.plist',
},
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698