Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1652873004: Print stack trace when Dart_SetReturnValue is passed UnwindError. (Closed)

Created:
4 years, 10 months ago by turnidge
Modified:
4 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Print stack trace when Dart_SetReturnValue is passed UnwindError. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/2232a52ff8b93289ec7cc8f4ace2e0ac78a8db55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M runtime/lib/core_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/lib/stacktrace.h View 1 chunk +22 lines, -0 lines 0 comments Download
M runtime/lib/stacktrace.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
4 years, 10 months ago (2016-02-01 18:40:02 UTC) #2
Cutch
lgtm
4 years, 10 months ago (2016-02-01 18:41:07 UTC) #3
turnidge
4 years, 10 months ago (2016-02-01 18:46:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2232a52ff8b93289ec7cc8f4ace2e0ac78a8db55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698