Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/src/fpdfview.cpp

Issue 1652873003: Pdfium does not create isolate when it runs in chromium (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/include/fpdfxfa/fpdfxfa_app.h ('k') | fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp » ('j') | xfa/src/fxjse/src/runtime.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/fpdfview.cpp
diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp
index ba647093eb95b9f7046c69dbe84f44f37c93a29b..b1cf139e384ef64bfa8f95a227912da06217f437 100644
--- a/fpdfsdk/src/fpdfview.cpp
+++ b/fpdfsdk/src/fpdfview.cpp
@@ -241,7 +241,8 @@ DLLEXPORT void STDCALL FPDF_InitLibraryWithConfig(
pModuleMgr->InitPageModule();
pModuleMgr->InitRenderModule();
#ifdef PDF_ENABLE_XFA
- CPDFXFA_App::GetInstance()->Initialize();
+ CPDFXFA_App::GetInstance()->Initialize(
+ (cfg && cfg->version >= 2) ? (FXJSE_HRUNTIME)cfg->m_pIsolate : nullptr);
jun_fang 2016/02/01 11:01:19 Use C++ style cast.
jun_fang 2016/02/01 11:01:19 currently, we don't have the version which is larg
Jim Wang 2016/02/02 03:43:17 Follow the code in line 252.
Jim Wang 2016/02/02 03:43:17 Done.
#else // PDF_ENABLE_XFA
pModuleMgr->LoadEmbeddedGB1CMaps();
pModuleMgr->LoadEmbeddedJapan1CMaps();
« no previous file with comments | « fpdfsdk/include/fpdfxfa/fpdfxfa_app.h ('k') | fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp » ('j') | xfa/src/fxjse/src/runtime.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698