Android: Use virtualized context only for those with compatible config

ui/gl/gl_context_osmesa.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_context_osmesa.h"
 
 #include <GL/osmesa.h>
 
 #include "base/logging.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gl/gl_bindings.h"
 #include "ui/gl/gl_surface.h"
 
 namespace gfx {
 
 GLContextOSMesa::GLContextOSMesa(GLShareGroup* share_group)
     : GLContextReal(share_group),
       context_(nullptr),
       is_released_(false) {
 }
 
 bool GLContextOSMesa::Initialize(GLSurface* compatible_surface,
                                  GpuPreference gpu_preference) {
   DCHECK(!context_);
 
   OSMesaContext share_handle = static_cast<OSMesaContext>(
       share_group() ? share_group()->GetHandle() : nullptr);
 
-  GLuint format = compatible_surface->GetFormat();
+  GLuint format = 0;
+  switch (compatible_surface->GetFormat()) {
+    case GLSurface::SURFACE_OSMESA_BGRA:
+      format = OSMESA_BGRA;
+      break;
+    case GLSurface::SURFACE_OSMESA_RGBA:
+      format = OSMESA_RGBA;
+      break;
+    default:

[no sievers, 2016/02/22 22:50:03]

nit: NOTREACHED() (and remove line 40). Maybe we should even return 'false' here
since the further behavior seems undefined (it should fail below, but what do
you end up if it doesn't?).

[Jinsuk Kim, 2016/02/23 01:27:38]

Done.

+      break;
+  }
   DCHECK_NE(format, (unsigned)0);
   context_ = OSMesaCreateContextExt(format,
                                     0,  // depth bits
                                     0,  // stencil bits
                                     0,  // accum bits
                                     share_handle);
   if (!context_) {
     LOG(ERROR) << "OSMesaCreateContextExt failed.";
     return false;
   }
@@ skipping 94 matching lines @@
 
 void GLContextOSMesa::OnSetSwapInterval(int interval) {
   DCHECK(IsCurrent(nullptr));
 }
 
 GLContextOSMesa::~GLContextOSMesa() {
   Destroy();
 }
 
 }  // namespace gfx