Stop resource loading for WebCore::MediaDocument...

webkit/glue/webframeloaderclient_impl.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include <string>
 #include <vector>
 
 #include "Chrome.h"
@@ skipping 964 matching lines @@
 }
 
 // Called whenever data is received.
 void WebFrameLoaderClient::committedLoad(DocumentLoader* loader, const char* data, int length) {
   if (!plugin_widget_.get()) {
     WebViewDelegate* d = webframe_->GetWebViewImpl()->delegate();
     if (d)
       d->DidReceiveDocumentData(webframe_, data, length);
   }
 
+  // If we are sending data to WebCore::MediaDocument, we should stop here

[darin (slow to review), 2009/08/14 00:15:37]

One more tweak I would make:  move this code to the top of the function and
return after cancelling the main resource load.  There is no reason to call
DidReceiveDocumentData in this case, right?  Or, does that initial bit of
document data cause the isMediaDocument flag to be set?

[Alpha Left Google, 2009/08/14 00:32:13]

Yes, it is the first bit of data that triggers the isMediaDocument(), if we move
this block up and return it will actually cause rendering problem (a red page is
displayed). 

[darin (slow to review), 2009/08/14 07:30:44]

OK, that makes sense.  Thanks!

+  // and cancel the request.
+  if (webframe_->frame()->document() &&
+      webframe_->frame()->document()->isMediaDocument()) {
+    loader->cancelMainResourceLoad(
+        pluginWillHandleLoadError(loader->response()));
+  }
+
   // The plugin widget could have been created in the webframe_->DidReceiveData
   // function.
   if (plugin_widget_.get()) {
     if (!sent_initial_response_to_plugin_) {
       sent_initial_response_to_plugin_ = true;
       plugin_widget_->didReceiveResponse(
           webframe_->frame()->loader()->activeDocumentLoader()->response());
     }
     plugin_widget_->didReceiveData(data, length);
   }
@@ skipping 433 matching lines @@
 
   std::string offset_str = url.ExtractFileName();
   int offset;
   if (!StringToInt(offset_str, &offset))
     return;
 
   WebViewDelegate* d = webframe_->GetWebViewImpl()->delegate();
   if (d)
     d->NavigateBackForwardSoon(offset);
 }