src/runtime.cc - Issue 16528009: Deprecate the version of MakeWeak which takes an Isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 16528009: Deprecate the version of MakeWeak which takes an Isolate. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: rebased Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index e46297253757d0d833cfdd3363c744a165c5de5a..4019b7ec5c6157a49cedfec2b8e699514b409619 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -714,7 +714,7 @@ bool Runtime::SetupArrayBufferAllocatingData(

v8::Isolate* external_isolate = reinterpret_cast<v8::Isolate*>(isolate);

v8::Persistent<v8::Value> weak_handle(

external_isolate, v8::Utils::ToLocal(Handle<Object>::cast(array_buffer)));

- weak_handle.MakeWeak(external_isolate, data, ArrayBufferWeakCallback);

+ weak_handle.MakeWeak(data, ArrayBufferWeakCallback);

weak_handle.MarkIndependent(external_isolate);

isolate->heap()->AdjustAmountOfExternalAllocatedMemory(allocated_length);

« no previous file with comments | « src/d8.cc ('k') | test/cctest/test-api.cc » ('j') | no next file with comments »