Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 16528009: Deprecate the version of MakeWeak which takes an Isolate. (Closed)

Created:
7 years, 6 months ago by marja
Modified:
7 years, 6 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Deprecate the version of MakeWeak which takes an Isolate. BUG=NONE R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15105

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -53 lines) Patch
M include/v8.h View 1 2 2 chunks +24 lines, -10 lines 0 comments Download
M src/d8.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 14 chunks +34 lines, -38 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
marja
dcarney, svenpanne, ptal
7 years, 6 months ago (2013-06-12 11:36:08 UTC) #1
Sven Panne
lgtm
7 years, 6 months ago (2013-06-12 11:50:40 UTC) #2
dcarney
7 years, 6 months ago (2013-06-13 07:23:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r15105 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698