Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Issue 16528005: Add layout test to verify that global constructors in workers environment have right attributes (Closed)

Created:
7 years, 6 months ago by do-not-use
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, lgombos
Visibility:
Public.

Description

Add layout test to verify that global constructors in workers environment have right attributes New test is added to webexposed/ folder. The corresponding test for non-workers is moved the webexposed/ folder as well for consistency. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152107

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move to webexposed #

Patch Set 3 : Rebase on master #

Messages

Total messages: 14 (0 generated)
do-not-use
7 years, 6 months ago (2013-06-06 06:41:56 UTC) #1
haraken
LGTM https://codereview.chromium.org/16528005/diff/1/LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js File LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js (right): https://codereview.chromium.org/16528005/diff/1/LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js#newcode27 LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js:27: descriptorShouldBe("global", "'Float64Array'", {writable: true, enumerable: false, configurable: true, ...
7 years, 6 months ago (2013-06-06 06:45:27 UTC) #2
do-not-use
https://codereview.chromium.org/16528005/diff/1/LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js File LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js (right): https://codereview.chromium.org/16528005/diff/1/LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js#newcode27 LayoutTests/fast/js/script-tests/global-constructors-attributes-worker.js:27: descriptorShouldBe("global", "'Float64Array'", {writable: true, enumerable: false, configurable: true, value:"Float64Array"}); ...
7 years, 6 months ago (2013-06-06 06:53:26 UTC) #3
haraken
Makes sense!
7 years, 6 months ago (2013-06-06 06:54:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16528005/1
7 years, 6 months ago (2013-06-06 06:55:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=11724
7 years, 6 months ago (2013-06-06 07:26:02 UTC) #6
eseidel
If you'd liek this tested with teh stable configuration of Chromium (the flags we actually ...
7 years, 6 months ago (2013-06-06 08:56:40 UTC) #7
do-not-use
On 2013/06/06 08:56:40, eseidel wrote: > If you'd liek this tested with teh stable configuration ...
7 years, 6 months ago (2013-06-06 10:12:42 UTC) #8
do-not-use
On 2013/06/06 10:12:42, Christophe Dumez wrote: > On 2013/06/06 08:56:40, eseidel wrote: > > If ...
7 years, 6 months ago (2013-06-10 05:49:19 UTC) #9
haraken
> > Done. I have moved the corresponding test for non-workers as well, for > ...
7 years, 6 months ago (2013-06-10 05:49:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16528005/12001
7 years, 6 months ago (2013-06-10 05:50:51 UTC) #11
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1377
7 years, 6 months ago (2013-06-10 06:02:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/16528005/23001
7 years, 6 months ago (2013-06-10 07:25:08 UTC) #13
commit-bot: I haz the power
7 years, 6 months ago (2013-06-10 08:03:41 UTC) #14
Message was sent while issue was closed.
Change committed as 152107

Powered by Google App Engine
This is Rietveld 408576698