Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1652793002: Ship RegExp subclassing (Closed)

Created:
4 years, 10 months ago by Dan Ehrenberg
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship RegExp subclassing This patch ships the first part of RegExp subclassing--defining Symbol.{match,replace,search,split}, but keeping their original definitions which are restricted to a RegExp receiver and do not call out to the core 'exec' method. This is being shipped separately because the two sets of extension points are separate features with separate functionality. The amount of behavior which is held behind the flag is very small, just exposing the symbols as properties of Symbol--the behavior that the String methods call out to these Symbol properties has already been shipping unflagged. R=yangguo@chromium.org BUG=v8:4305, v8:4343, v8:4344, v8:4345 LOG=Y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/4e982c0d3542757d81dc8dfaeaba778b6bcda739 Cr-Commit-Position: refs/heads/master@{#33629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/flag-definitions.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652793002/1
4 years, 10 months ago (2016-01-31 17:08:18 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-31 18:13:18 UTC) #4
Dan Ehrenberg
4 years, 10 months ago (2016-01-31 18:14:52 UTC) #5
Yang
On 2016/01/31 18:14:52, Dan Ehrenberg wrote: lgtm.
4 years, 10 months ago (2016-02-01 07:18:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1652793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1652793002/1
4 years, 10 months ago (2016-02-01 07:20:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 07:22:18 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 07:22:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e982c0d3542757d81dc8dfaeaba778b6bcda739
Cr-Commit-Position: refs/heads/master@{#33629}

Powered by Google App Engine
This is Rietveld 408576698