Updated decode logic to estimate timestamps if the demuxer has not assigned o...

Updated decode logic to estimate timestamps if the demuxer has not assigned one.
BUG=18208, 18726
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23038

[fbarchard, 2009-08-10 23:19:17]

LGTM with nit on comment

http://codereview.chromium.org/165270/diff/1/2
File media/filters/ffmpeg_audio_decoder.h (right):

http://codereview.chromium.org/165270/diff/1/2#newcode48
Line 48: // Estimated timestamp for next packet. Useful to replace garbage
packets.
I wouldnt call them garbage packets... I'd call them packets with no time stamp

[scherkus (not reviewing), 2009-08-10 23:48:00]

LGTM with nits

http://codereview.chromium.org/165270/diff/1/3
File media/filters/ffmpeg_audio_decoder.cc (right):

http://codereview.chromium.org/165270/diff/1/3#newcode19
Line 19: estimated_next_timestamp_() {
you can remove this line

http://codereview.chromium.org/165270/diff/1/3#newcode124
Line 124: // Use our estimate for the timestamp if |input| has an invalid one.
"has an invalid one" -> "doesn't have one"

[kylep, 2009-08-11 00:11:55]

http://codereview.chromium.org/165270/diff/1/3
File media/filters/ffmpeg_audio_decoder.cc (right):

http://codereview.chromium.org/165270/diff/1/3#newcode19
Line 19: estimated_next_timestamp_() {
On 2009/08/10 23:48:00, scherkus wrote:
> you can remove this line

Done.

http://codereview.chromium.org/165270/diff/1/3#newcode124
Line 124: // Use our estimate for the timestamp if |input| has an invalid one.
On 2009/08/10 23:48:00, scherkus wrote:
> "has an invalid one" -> "doesn't have one"

Done.

http://codereview.chromium.org/165270/diff/1/2
File media/filters/ffmpeg_audio_decoder.h (right):

http://codereview.chromium.org/165270/diff/1/2#newcode48
Line 48: // Estimated timestamp for next packet. Useful to replace garbage
packets.
On 2009/08/10 23:19:17, fbarchard wrote:
> I wouldnt call them garbage packets... I'd call them packets with no time
stamp

Done.

[scherkus (not reviewing), 2009-08-11 00:13:21]

LGTM

I hope you tested the whole matrix ;)

[kylep, 2009-08-11 01:07:16]

Ok, I have verified that everything in the test matrix plays without
difficulty from this patch.

On Mon, Aug 10, 2009 at 5:13 PM, <scherkus@chromium.org> wrote:

> LGTM
>
> I hope you tested the whole matrix ;)
>
>
> http://codereview.chromium.org/165270
>

[scherkus (not reviewing), 2009-08-11 01:08:24]

well then.. commit!