Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1773)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

Issue 1652603003: [Findit] Modify result page to display tryjob result for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@1228-try-job-pipeline-for-test-failure
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« appengine/findit/handlers/try_job_result.py ('K') | « appengine/findit/templates/build_failure.html ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
diff --git a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
index 83d8fbb4282df3a6bea19390581c6e30df2c7a39..52e2339fa9babd5e19124aeafd621e4a3be3abe3 100644
--- a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
+++ b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py
@@ -180,7 +180,9 @@ class IdentifyTryJobCulpritPipeline(BasePipeline):
failed_revisions = [failed_revision] if failed_revision else []
culprits = self._GetCulpritInfo(failed_revisions)
if culprits:
- result['culprit'] = culprits[failed_revision]
+ result['culprit'] = {
+ 'compile': culprits[failed_revision]
+ }
else: # try_job_type is 'test'.
culprit_map, failed_revisions = self._FindCulpritForEachTestFailure(
blame_list, result)
« appengine/findit/handlers/try_job_result.py ('K') | « appengine/findit/templates/build_failure.html ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698