[Findit] Modify result page to display tryjob result for test failure.

appengine/findit/templates/build_failure.html

Index: appengine/findit/templates/build_failure.html
diff --git a/appengine/findit/templates/build_failure.html b/appengine/findit/templates/build_failure.html
index a001a21489ee9e1105f56f67b3e97b66c147624e..dd31554ebcaccfdb8e8203cc816099691c2a7f81 100644
--- a/appengine/findit/templates/build_failure.html
+++ b/appengine/findit/templates/build_failure.html
@@ -263,32 +263,33 @@
     function displayTryJobResult() {
       $.getJSON('try-job-result?url=' + findit.buildUrl, function(data) {
           if (! jQuery.isEmptyObject(data)) {
-            $('#try_job_status').html(data.status);
-            if (data.status == 'Error') {
-              $('#try_job_status').addClass('error');
-            } else if(data.status == 'Analyzed') {
-              $('#try_job_status').addClass('completed');
-            } else {
-              $('#try_job_status').append(', will refresh in 1 minute...');
-              $('#try_job_status').addClass('running');
-            }
-            if ('try_job_url' in data) {
-              $('#try_job_url').html(' <a href="' + data.try_job_url + '">try job url</a>');
-            }
-
-            var tryJobStr = '';
-            var repeatStatusList = ["Pending", "Analyzing"]
-            if (repeatStatusList.indexOf(data.status) > -1) {
-              $('#try_job_result').addClass('not-display');
-              setTimeout(displayTryJobResult, 60000);
-            } else if (data.status == 'Analyzed' && 'review_url' in data) {
-              tryJobStr += '<br>culprit: <a href="' + data.review_url + '">';
-              tryJobStr += data.commit_position || data.revision + '</a>';
-              $('#try_job_result').html(tryJobStr);
-              $('#try_job_result').removeClass('not-display');
-            } else {
-              $('#try_job_result').addClass('not-display');
-            }
+            tableString = '<table><tr><th>Step</th><th>Test</th><th>Try Job</th><th>Status</th><th>Culprit</th></tr>';

[stgao, 2016/02/02 21:08:32]

Define local var instead of global one?

[chanli, 2016/02/02 22:18:13]

Done.

+            $.each(data, function(key, value) {
+              tableString += '<tr>';
+              tableString += '<td>' + value.step + '</td>';
+              tableString += '<td>' + value.test + '</td>';

[stgao, 2016/02/02 21:08:32]

Just to double check, the value.test will be 'N/A' if the failure is step-level
like compile, right?

[chanli, 2016/02/02 22:18:13]

Yes.

+              if (value.try_job_url) {
+                tableString += '<td><a href="' + value.try_job_url + '">' + value.try_job_build_number + '</a></td>';
+              } else {
+                tableString += '<td></td>';
+              }
+              if (value.status == 'Completed') {
+                status_class = 'completed';
+              } else if (value.status == 'Error') {
+                status_class = 'error';
+              } else {
+                status_class = 'running';

[stgao, 2016/02/02 21:08:32]

Besides these, there is one more status -- scheduled, right?

[chanli, 2016/02/02 22:18:12]

Right. But scheduled and running will share the same CSS class.

+              }
+              tableString += '<td><span class="' + status_class + '">' + value.status + '</span></td>';
+              if (value.revision) {
+                tableString += '<td><a href=">' + value.review_url + '">' + value.commit_position || value.revision + '</a></td>';

[stgao, 2016/02/02 21:08:33]

note: review url might not be available.

[chanli, 2016/02/02 22:18:12]

Done.

+              } else {
+                tableString += '<td>Not Found</td>';
+              }
+              tableString += '</tr>';
+            });
+            tableString += '</table>';
+            $('#try_job_result').html(tableString);
           } else {
             $('#try_job').addClass('not-display');
           }
@@ -366,9 +367,7 @@
 
   <div id='try_job'>

[stgao, 2016/02/02 21:08:32]

I guess this should be hidden by default.

[chanli, 2016/02/02 22:18:12]

Done.

     <b> Try Job Result:</b>
-    <br>
-    status: <span id='try_job_status'></span><span id="try_job_url"></span>
-    <span id='try_job_result'></span>
+    <div id='try_job_result'></div>
     <br>
   </div>
   <br>