appengine/findit/waterfall/identify_try_job_culprit_pipeline.py - Issue 1652603003: [Findit] Modify result page to display tryjob result for test failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

Issue 1652603003: [Findit] Modify result page to display tryjob result for test failure. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@1228-try-job-pipeline-for-test-failure

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/templates/build_failure.html ('k') | appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

diff --git a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

index 552b04f0e776e2a881878c5a393adde3ef354243..fdea4a155949861b56974a48dacbf9b75ecba04c 100644

--- a/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

+++ b/appengine/findit/waterfall/identify_try_job_culprit_pipeline.py

@@ -197,7 +197,9 @@ class IdentifyTryJobCulpritPipeline(BasePipeline):

failed_revisions = [failed_revision] if failed_revision else []

culprits = self._GetCulpritInfo(failed_revisions)

if culprits:

- result['culprit'] = culprits[failed_revision]

+ result['culprit'] = {

+ 'compile': culprits[failed_revision]

+ }

try_job_data.culprits = {'compile': failed_revision}

else: # try_job_type is 'test'.

culprit_map, failed_revisions = self._FindCulpritForEachTestFailure(